lkml.org 
[lkml]   [2007]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] i386: unexport machine_id
On Mon, 27 Aug 2007 23:28:08 +0200 Adrian Bunk <bunk@kernel.org> wrote:

> This patch removes the unused EXPORT_SYMBOL(machine_id).
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
> This patch has been sent on:
> - 14 Aug 2007
>
> --- a/arch/i386/kernel/setup.c
> +++ b/arch/i386/kernel/setup.c
> @@ -86,9 +86,6 @@ unsigned long mmu_cr4_features;
>
> /* for MCA, but anyone else can use it if they want */
> unsigned int machine_id;
> -#ifdef CONFIG_MCA
> -EXPORT_SYMBOL(machine_id);
> -#endif
> unsigned int machine_submodel_id;
> unsigned int BIOS_revision;
> unsigned int mca_pentium_flag;

You know my position on removal of exports with no warning.

If the relevant maintainer chooses to apply the patch then ho hum I have
other things to think about. Your best shot at getting this sort of thing
merged would be to cc the appropriate maintainer.

Or, better, use __deprecated_for_modules. That's what it was added for.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-28 10:11    [W:0.053 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site