lkml.org 
[lkml]   [2007]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/4] add killattr inode operation to allow filesystems to interpret ATTR_KILL_S*ID bits
On Tue, Aug 28, 2007 at 08:11:14PM +0100, Christoph Hellwig wrote:
>
> Sorry for not replying to the previsious revisions, but I've been out
> for on vacation.
>
> I can't say I like this version. Now we've got callouts at two rather close
> levels which is not very nice from the interface POV.
>
> Maybe preference is for the first scheme where we simply move interpreation
> of the ATTR_KILL_SUID/ATTR_KILL_SGID into the setattr routine and provide
> a nice helper for the normal filesystem to use.
>
> If people are really concerned about adding two lines of code to the
> handfull of setattr operation there's a variant of this scheme that can
> avoid it:

It's not about adding 2 lines of code - it's about adding the requirement
for the fs to call a function.

> - notify_change is modified to not clear the ATTR_KILL_SUID/ATTR_KILL_SGID
> but update ia_mode and the ia_valid flag to include ATTR_MODE.
> - disk filesystems stay unchanged and never look at
> ATTR_KILL_SUID/ATTR_KILL_SGID, but nfs can check for it and ignore
> the ATTR_MODE flags and ia_valid in this case and do the right thing
> on the server side.

Sounds reasonable.

Josef 'Jeff' Sipek.

--
I abhor a system designed for the "user", if that word is a coded pejorative
meaning "stupid and unsophisticated."
- Ken Thompson
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-28 21:37    [W:0.111 / U:1.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site