lkml.org 
[lkml]   [2007]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: CONFIG_HOTPLUG_CPU: kconfig bug?
    On Mon, 27 Aug 2007, Sam Ravnborg wrote:
    > On Mon, Aug 27, 2007 at 03:54:49PM +0100, Hugh Dickins wrote:
    > > Hi Roman,
    > >
    > > I've noticed an oddity with CONFIG_HOTPLUG_CPU in 2.6.23-rc:
    > > make oldconfig seems to turn it on even when nothing wants it,
    > > increasing kernel size by about 10k; but if you then edit the
    > > line out of .config and make oldconfig again, it correctly
    > > offers the choice and lets it be turned off after all.
    > >
    > > (I've not actually tried make anything_else_config.)
    > >
    > > Attached is a 2.6.23-rc1 i386 SMP .config, CONFIG_HOTPLUG_CPU
    > > not set, with which it should be easy to reproduce the issue: just
    > > make oldconfig in an -rc2 or current kernel tree (being sure to
    > > choose N for SUSPEND and HIBERNATION: those rightly select it).
    >
    > I tried to reproduce this with no luck:
    >
    > $ mv hugh .config
    > $ make
    > scripts/kconfig/conf -s arch/i386/Kconfig
    > *
    > * Restart config...
    > *
    > *
    > * Power management options (ACPI, APM)
    > *
    > Power Management support (PM) [Y/n/?] y
    > Legacy Power Management API (DEPRECATED) (PM_LEGACY) [N/y/?] n
    > Power Management Debug Support (PM_DEBUG) [N/y/?] n
    > Suspend to RAM and standby (SUSPEND) [Y/n/?] (NEW) n <= I selected 'n'
    > Hibernation (aka 'suspend to disk') (HIBERNATION) [N/y/?] (NEW) n <= I selected 'n'
    > *
    > * Fusion MPT device support
    > *
    > Fusion MPT ScsiHost drivers for SPI (FUSION_SPI) [Y/n/m/?] y
    > Fusion MPT ScsiHost drivers for FC (FUSION_FC) [N/m/y/?] n
    > Fusion MPT ScsiHost drivers for SAS (FUSION_SAS) [N/m/y/?] n
    > Maximum number of scatter gather entries (16 - 128) (FUSION_MAX_SGE) [128] 128
    > Fusion MPT misc device (ioctl) driver (FUSION_CTL) [N/m/y/?] n
    > Fusion MPT logging facility (FUSION_LOGGING) [N/y/?] (NEW)
    > #
    > # configuration written to .config
    > #
    > CHK include/linux/version.h
    > CHK include/linux/utsrelease.h
    > make: *** [_all] Interrupt
    >
    > $ grep HOTPLUG_CPU .config
    > # CONFIG_HOTPLUG_CPU is not set
    >
    > If you let kbuild do a silentoldconfig then I expect
    > it to be set due to SUSPEND being set.
    >
    > If you can still reproduce it could you then explan the
    > exect stepts to do so.
    >
    > PS. I used latest -linus as of yesterday.

    Interesting, thanks a lot for trying. Doing it your way (saying
    "make" without a preparatory "make oldconfig") gives me the same
    result as you, CONFIG_HOTPLUG_CPU is not set. But doing it my way
    ("make oldconfig" as I indicated) gives me CONFIG_HOTPLUG_CPU=y as
    before - please try an explicit "make oldconfig" and I expect
    you'll find the same.

    Hugh
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-27 22:53    [W:0.024 / U:29.728 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site