Messages in this thread | | | From | Al Boldi <> | Subject | Re: CFS review | Date | Mon, 27 Aug 2007 07:06:41 +0300 |
| |
Ingo Molnar wrote: > * Al Boldi <a1426z@gawab.com> wrote: > > > and could you also check 20.4 on 2.6.22.5 perhaps, or very latest > > > -git? (Peter has experienced smaller spikes with that.) > > > > Ok, I tried all your suggestions, but nothing works as smooth as > > removing __update_curr. > > could you send the exact patch that shows what you did?
On 2.6.22.5-v20.3 (not v20.4):
340- curr->delta_exec += delta_exec; 341- 342- if (unlikely(curr->delta_exec > sysctl_sched_stat_granularity)) { 343:// __update_curr(cfs_rq, curr); 344- curr->delta_exec = 0; 345- } 346- curr->exec_start = rq_of(cfs_rq)->clock;
> And could you > also please describe it exactly which aspect of the workload you call > 'smooth'. Could it be made quantitative somehow?
The 3x gears test shows the startup problem in a really noticeable way. With v20.4 they startup surging and stalling periodically for about 10sec, then they are smooth. With v20.3 + above patch they startup completely smooth.
Thanks!
-- Al - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |