Messages in this thread |  | | Date | Fri, 24 Aug 2007 06:43:33 -0400 (EDT) | From | "Robert P. J. Day" <> | Subject | Re: [PATCH 09/30] mtd: Don't cast kmalloc() return value in drivers/mtd/maps/pmcmsp-flash.c |
| |
On Fri, 24 Aug 2007, Denys Vlasenko wrote:
> On Friday 24 August 2007 00:52, Jesper Juhl wrote: > > kmalloc() returns a void pointer. > > No need to cast it. > > > - msp_flash = (struct mtd_info **)kmalloc( > > - fcnt * sizeof(struct map_info *), GFP_KERNEL); > > - msp_parts = (struct mtd_partition **)kmalloc( > > - fcnt * sizeof(struct mtd_partition *), GFP_KERNEL); > > - msp_maps = (struct map_info *)kmalloc( > > - fcnt * sizeof(struct mtd_info), GFP_KERNEL); > > + msp_flash = kmalloc(fcnt * sizeof(struct map_info *), GFP_KERNEL); > > + msp_parts = kmalloc(fcnt * sizeof(struct mtd_partition *), GFP_KERNEL); > > + msp_maps = kmalloc(fcnt * sizeof(struct mtd_info), GFP_KERNEL); > > memset(msp_maps, 0, fcnt * sizeof(struct mtd_info)); > > This one wants kzalloc. > > > - msp_parts[i] = (struct mtd_partition *)kmalloc( > > - pcnt * sizeof(struct mtd_partition), GFP_KERNEL); > > + msp_parts[i] = kmalloc(pcnt * sizeof(struct mtd_partition), > > + GFP_KERNEL); > > memset(msp_parts[i], 0, pcnt * sizeof(struct mtd_partition)); > > > > /* now initialize the devices proper */ > > Same
actually, i would think kcalloc would be more appropriate here, no?
rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA
http://crashcourse.ca ======================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |