lkml.org 
[lkml]   [2007]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/30] mtd: Don't cast kmalloc() return value in drivers/mtd/maps/pmcmsp-flash.c
On 24/08/07, Denys Vlasenko <vda.linux@googlemail.com> wrote:
> On Friday 24 August 2007 00:52, Jesper Juhl wrote:
> > kmalloc() returns a void pointer.
> > No need to cast it.
>
> > - msp_flash = (struct mtd_info **)kmalloc(
> > - fcnt * sizeof(struct map_info *), GFP_KERNEL);
> > - msp_parts = (struct mtd_partition **)kmalloc(
> > - fcnt * sizeof(struct mtd_partition *), GFP_KERNEL);
> > - msp_maps = (struct map_info *)kmalloc(
> > - fcnt * sizeof(struct mtd_info), GFP_KERNEL);
> > + msp_flash = kmalloc(fcnt * sizeof(struct map_info *), GFP_KERNEL);
> > + msp_parts = kmalloc(fcnt * sizeof(struct mtd_partition *), GFP_KERNEL);
> > + msp_maps = kmalloc(fcnt * sizeof(struct mtd_info), GFP_KERNEL);
> > memset(msp_maps, 0, fcnt * sizeof(struct mtd_info));
>
> This one wants kzalloc.
>
> > - msp_parts[i] = (struct mtd_partition *)kmalloc(
> > - pcnt * sizeof(struct mtd_partition), GFP_KERNEL);
> > + msp_parts[i] = kmalloc(pcnt * sizeof(struct mtd_partition),
> > + GFP_KERNEL);
> > memset(msp_parts[i], 0, pcnt * sizeof(struct mtd_partition));
> >
> > /* now initialize the devices proper */
>
> Same

Ok, thank you for that feedback.
I'll respin the patch with that change when I resubmit all the ones
that don't get picked up (probably next week).

--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-24 12:51    [W:0.077 / U:8.092 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site