lkml.org 
[lkml]   [2007]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: DM_MULTIPATH_RDAC: "scsi_normalize_sense" undefined
    On Fri, 24 Aug 2007 14:33:02 -0700 Chandra Seetharaman wrote:

    > It does, but "rdac" _is_ for a SCSI device.

    It does __what__ ? depend on SCSI?
    I don't see that in drivers/md/Kconfig.
    Sounds like Martin is correct, SCSI needs to be added, like below.


    > What device are you using it with ?
    >
    > On Fri, 2007-08-24 at 18:08 +0200, Martin Michlmayr wrote:
    > > I just got:
    > >
    > > Building modules, stage 2.
    > > MODPOST 414 modules
    > > ERROR: "scsi_normalize_sense" [drivers/md/dm-rdac.ko] undefined!
    > > make[1]: *** [__modpost] Error 1
    > >
    > > Presumably DM_MULTIPATH_RDAC needs to depend on SCSI (not enabled
    > > here) since it uses scsi_normalize_sense.

    ---

    From: Randy Dunlap <randy.dunlap@oracle.com>

    DM_MULTIPATH_RDAC uses SCSI API(s) and is for a SCSI device,
    so add SCSI to its depends on to prevent build errors.

    Not tested.

    Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
    ---
    drivers/md/Kconfig | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- linux-2.6.23-rc3-git6.orig/drivers/md/Kconfig
    +++ linux-2.6.23-rc3-git6/drivers/md/Kconfig
    @@ -263,7 +263,7 @@ config DM_MULTIPATH_EMC

    config DM_MULTIPATH_RDAC
    tristate "LSI/Engenio RDAC multipath support (EXPERIMENTAL)"
    - depends on DM_MULTIPATH && BLK_DEV_DM && EXPERIMENTAL
    + depends on DM_MULTIPATH && BLK_DEV_DM && SCSI && EXPERIMENTAL
    ---help---
    Multipath support for LSI/Engenio RDAC.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-08-25 00:03    [W:0.022 / U:61.516 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site