lkml.org 
[lkml]   [2007]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 28/30] jfs: avoid pointless casts of kmalloc() return val
From
Date
Thanks, but Jack Stone submitted the same patch a few weeks ago.  It's
already in the jfs git tree and the -mm kernel.

Shaggy

On Fri, 2007-08-24 at 02:36 +0200, Jesper Juhl wrote:
> There's no need to cast the, void *, return value of kmalloc() when
> assigning to a pointer variable.
>
> Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
> ---
> fs/jfs/jfs_dtree.c | 8 ++------
> 1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/fs/jfs/jfs_dtree.c b/fs/jfs/jfs_dtree.c
> index c14ba3c..3f15b36 100644
> --- a/fs/jfs/jfs_dtree.c
> +++ b/fs/jfs/jfs_dtree.c
> @@ -592,9 +592,7 @@ int dtSearch(struct inode *ip, struct component_name * key, ino_t * data,
> struct component_name ciKey;
> struct super_block *sb = ip->i_sb;
>
> - ciKey.name =
> - (wchar_t *) kmalloc((JFS_NAME_MAX + 1) * sizeof(wchar_t),
> - GFP_NOFS);
> + ciKey.name = kmalloc((JFS_NAME_MAX + 1) * sizeof(wchar_t), GFP_NOFS);
> if (ciKey.name == 0) {
> rc = -ENOMEM;
> goto dtSearch_Exit2;
> @@ -957,9 +955,7 @@ static int dtSplitUp(tid_t tid,
> smp = split->mp;
> sp = DT_PAGE(ip, smp);
>
> - key.name =
> - (wchar_t *) kmalloc((JFS_NAME_MAX + 2) * sizeof(wchar_t),
> - GFP_NOFS);
> + key.name = kmalloc((JFS_NAME_MAX + 2) * sizeof(wchar_t), GFP_NOFS);
> if (key.name == 0) {
> DT_PUTPAGE(smp);
> rc = -ENOMEM;
--
David Kleikamp
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-24 06:23    [W:0.208 / U:10.052 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site