[lkml]   [2007]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [-mm patch] enforce noreplace-smp in alternative_instructions()
    Frederik Deweerdt wrote:
    > On Wed, Aug 22, 2007 at 02:06:48AM -0700, Andrew Morton wrote:
    > Hi Jeremy,
    > arch/i386/kernel/alternative.c:alternative_instructions() doesn't
    > check for noreplace-smp before setting capability bits and freeing the
    > __smp_locks section.
    > Every call to alternatives_smp_unlock() checks for noreplace-smp
    > beforehand, so remove the check from there.
    > Boot tested on i386 with UP+noreplace-smp (lguest) and SMP (real hardware)

    Does this fix a real problem? Or is there just some redundancy?
    Wouldn't it be better to put the noreplace_smp test in one place?

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-08-24 01:19    [W:0.024 / U:2.768 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site