lkml.org 
[lkml]   [2007]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86 msr driver: Misc cpuinit annotations
    Satyam Sharma wrote:
    > msr_class_cpu_callback() can be marked __cpuinit, being the notifier
    > callback for a __cpuinitdata notifier_block. So can be marked
    > msr_device_create() too, called only from the newly-__cpuinit
    > msr_class_cpu_callback() or from __init-marked msr_init().
    >
    > Signed-off-by: Satyam Sharma <satyam@infradead.org>

    Acked-by: H. Peter Anvin <hpa@zytor.com>

    > ---
    >
    > arch/i386/kernel/msr.c | 4 ++--
    > 1 files changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/arch/i386/kernel/msr.c b/arch/i386/kernel/msr.c
    > index 0c1069b..ac55d85 100644
    > --- a/arch/i386/kernel/msr.c
    > +++ b/arch/i386/kernel/msr.c
    > @@ -135,7 +135,7 @@ static const struct file_operations msr_fops = {
    > .open = msr_open,
    > };
    >
    > -static int msr_device_create(int i)
    > +static int __cpuinit msr_device_create(int i)
    > {
    > int err = 0;
    > struct device *dev;
    > @@ -146,7 +146,7 @@ static int msr_device_create(int i)
    > return err;
    > }
    >
    > -static int msr_class_cpu_callback(struct notifier_block *nfb,
    > +static int __cpuinit msr_class_cpu_callback(struct notifier_block *nfb,
    > unsigned long action, void *hcpu)
    > {
    > unsigned int cpu = (unsigned long)hcpu;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-24 00:59    [W:0.039 / U:0.084 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site