lkml.org 
[lkml]   [2007]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[2.6.20.17 review 41/58] drivers/video/macmodes.c:mac_find_mode() mustnt be __devinit
    If it's EXPORT_SYMBOL'ed it can't be __devinit.

    Reported by Mikael Pettersson.

    Signed-off-by: Adrian Bunk <bunk@stusta.de>
    Cc: "Antonino A. Daplas" <adaplas@pol.net>
    Cc: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    drivers/video/macmodes.c | 5 ++---
    drivers/video/macmodes.h | 8 ++++----
    2 files changed, 6 insertions(+), 7 deletions(-)

    diff --git a/drivers/video/macmodes.c b/drivers/video/macmodes.c
    index ab21495..083f603 100644
    --- a/drivers/video/macmodes.c
    +++ b/drivers/video/macmodes.c
    @@ -369,9 +369,8 @@ EXPORT_SYMBOL(mac_map_monitor_sense);
    *
    */

    -int __devinit mac_find_mode(struct fb_var_screeninfo *var,
    - struct fb_info *info, const char *mode_option,
    - unsigned int default_bpp)
    +int mac_find_mode(struct fb_var_screeninfo *var, struct fb_info *info,
    + const char *mode_option, unsigned int default_bpp)
    {
    const struct fb_videomode *db = NULL;
    unsigned int dbsize = 0;
    diff --git a/drivers/video/macmodes.h b/drivers/video/macmodes.h
    index babeb81..b86ba08 100644
    --- a/drivers/video/macmodes.h
    +++ b/drivers/video/macmodes.h
    @@ -55,10 +55,10 @@ extern int mac_vmode_to_var(int vmode, int cmode,
    extern int mac_var_to_vmode(const struct fb_var_screeninfo *var, int *vmode,
    int *cmode);
    extern int mac_map_monitor_sense(int sense);
    -extern int __devinit mac_find_mode(struct fb_var_screeninfo *var,
    - struct fb_info *info,
    - const char *mode_option,
    - unsigned int default_bpp);
    +extern int mac_find_mode(struct fb_var_screeninfo *var,
    + struct fb_info *info,
    + const char *mode_option,
    + unsigned int default_bpp);


    /*
    --
    1.5.2.5
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-22 11:17    [W:0.021 / U:60.120 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site