lkml.org 
[lkml]   [2007]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[2.6.20.17 review 42/58] nfsd: fix possible oops on re-insertion of rpcsec_gss modules
    The handling of the re-registration case is wrong here; the "test" that was
    returned from auth_domain_lookup will not be used again, so that reference
    should be put. And auth_domain_lookup never did anything with "new" in
    this case, so we should just clean it up ourself.

    Thanks to Akinobu Mita for bug report, analysis, and testing.

    Cc: Akinobu Mita <akinobu.mita@gmail.com>
    Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu>
    Cc: Neil Brown <neilb@suse.de>
    Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    net/sunrpc/auth_gss/svcauth_gss.c | 9 +++++----
    1 files changed, 5 insertions(+), 4 deletions(-)

    diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
    index 066c64a..6179767 100644
    --- a/net/sunrpc/auth_gss/svcauth_gss.c
    +++ b/net/sunrpc/auth_gss/svcauth_gss.c
    @@ -760,11 +760,12 @@ svcauth_gss_register_pseudoflavor(u32 pseudoflavor, char * name)
    new->h.flavour = &svcauthops_gss;
    new->pseudoflavor = pseudoflavor;

    + stat = 0;
    test = auth_domain_lookup(name, &new->h);
    - if (test != &new->h) { /* XXX Duplicate registration? */
    - auth_domain_put(&new->h);
    - /* dangling ref-count... */
    - goto out;
    + if (test != &new->h) { /* Duplicate registration */
    + auth_domain_put(test);
    + kfree(new->h.name);
    + goto out_free_dom;
    }
    return 0;

    --
    1.5.2.5
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-22 11:29    [W:0.021 / U:31.124 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site