lkml.org 
[lkml]   [2007]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 17/20] x86_64: Change PMDS invocation to single macro
    -stable review patch.  If anyone has any objections, please let us know.

    ------------------
    From: Andi Kleen <ak@suse.de>

    Very old binutils (2.12.90...) seem to have trouble with newlines
    in assembler macro invocation. They put them into the resulting
    argument expansion. In this case this lead to a parse error because
    a .rept expression ended up spread over multiple lines. Change the PMDS()
    invocation to a single line.

    Signed-off-by: Andi Kleen <ak@suse.de>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    arch/x86_64/kernel/head.S | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/arch/x86_64/kernel/head.S
    +++ b/arch/x86_64/kernel/head.S
    @@ -326,8 +326,7 @@ NEXT_PAGE(level2_kernel_pgt)
    /* 40MB kernel mapping. The kernel code cannot be bigger than that.
    When you change this change KERNEL_TEXT_SIZE in page.h too. */
    /* (2^48-(2*1024*1024*1024)-((2^39)*511)-((2^30)*510)) = 0 */
    - PMDS(0x0000000000000000, __PAGE_KERNEL_LARGE_EXEC|_PAGE_GLOBAL,
    - KERNEL_TEXT_SIZE/PMD_SIZE)
    + PMDS(0x0000000000000000, __PAGE_KERNEL_LARGE_EXEC|_PAGE_GLOBAL, KERNEL_TEXT_SIZE/PMD_SIZE)
    /* Module mapping starts here */
    .fill (PTRS_PER_PMD - (KERNEL_TEXT_SIZE/PMD_SIZE)),8,0

    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-21 09:01    [W:3.725 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site