Messages in this thread | | | Subject | Re: [PATCH] [12/58] x86_64: Add vDSO for x86-64 with gettimeofday/clock_gettime/getcpu | From | Daniel Walker <> | Date | Tue, 21 Aug 2007 09:25:01 -0700 |
| |
On Thu, 2007-07-19 at 11:54 +0200, Andi Kleen wrote: > + > +static noinline int do_realtime(struct timespec *ts) > +{ > + unsigned long seq, ns; > + do { > + seq = read_seqbegin(>od->lock); > + ts->tv_sec = gtod->wall_time_sec; > + ts->tv_nsec = gtod->wall_time_nsec; > + ns = vgetns(); > + } while (unlikely(read_seqretry(>od->lock, seq))); > + timespec_add_ns(ts, ns); > + return 0; > +}
Some thoughts ,
In the -mm kernel there is some debugging that gets injected into the likely/unlikely macros .. If they get called from userspace it causes a hang .. We might want to add some new set of macros to specifically denote that they are called from userspace, not just likely/unlikely but all the macros so we don't get mixed usage ..
Daniel
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |