Messages in this thread | | | Date | Mon, 20 Aug 2007 12:28:09 +0300 | From | "Pekka Enberg" <> | Subject | Re: [PATCH 04/10] mm: slub: add knowledge of reserve pages |
| |
Hi Peter,
On Mon, 2007-08-20 at 12:12 +0300, Pekka J Enberg wrote: > > Any reason why the callers that are actually interested in this don't do > > page->reserve on their own?
On 8/20/07, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote: > because new_slab() destroys the content?
Right. So maybe we could move the initialization parts of new_slab() to __new_slab() so that the callers that are actually interested in 'reserve' could do allocate_slab(), store page->reserve and do rest of the initialization with it?
As for the __GFP_WAIT handling, I *think* we can move the interrupt enable/disable to allocate_slab()... Christoph?
Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |