lkml.org 
[lkml]   [2007]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: gcc fixed size char array initialization bug - known?


    On Thu, 2 Aug 2007, Jan Engelhardt wrote:

    > On Aug 2 2007 21:55, Guennadi Liakhovetski wrote:
    > > [...]
    > >
    > > struct {
    > > char c[4];
    > > int i;
    > > } t;
    > > t.i = 0x12345678;
    > > strcpy(t.c, c);
    > >
    > >and t.i is silently corrupted. Just wanted to ask if this is known,
    > >really...
    >
    > What does this have to do with the kernel? The string "0123" is
    > generally _five_ characters long, so c[4] is not enough.
    > Or use strncpy.

    <nitpicking>

    While we're talking of null-termination of strings, then I bet you
    generally want to be using strlcpy(), really. Often strncpy() isn't
    what you want. Of course, if that buffer isn't a string at all, then
    you should be using memfoo() functions and not strbar() ones in the
    first place ...
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-03 05:07    [W:0.021 / U:12.736 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site