Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] ehca: map 4k firmware context of cq, qp to user space | Date | Thu, 2 Aug 2007 16:08:15 +0200 |
| |
On Thursday 02 August 2007, Hoang-Nam Nguyen wrote: > +#ifdef CONFIG_PPC_64K_PAGES > + /* make sure we map only 4k for fw context */ > + ret = remap_4k_pfn(vma, vma->vm_start, physical >> EHCA_PAGESHIFT, > + vma->vm_page_prot); > +#else > ret = remap_pfn_range(vma, vma->vm_start, physical >> PAGE_SHIFT, > vsize, vma->vm_page_prot); > +#endif
remap_4k_pfn is defined in terms of remap_pfn_range if the base page size if 4k, so you don't need this #ifdef afaics.
otherwise, the patch looks good.
Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |