lkml.org 
[lkml]   [2007]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: group ownership of tun devices -- nonfunctional?
    On 08/19/2007 06:05 PM, Bodo Eggert wrote:

    > IMHO the check is broken:
    >
    > + if (((tun->owner != -1 &&
    > + current->euid != tun->owner) ||
    > + (tun->group != -1 &&
    > + current->egid != tun->group)) &&
    > + !capable(CAP_NET_ADMIN))
    > return -EPERM;
    >
    > It should be something like:
    >
    > + if (!((tun->owner == tun->owner) ||
    > + (tun->group == tun->group) ||

    ???

    > + capable(CAP_NET_ADMIN)))
    > return -EPERM;
    >
    > Please verify and forward to the maintainers if my guess appears to be correct.

    Rene.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-19 18:39    [W:0.020 / U:0.912 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site