Messages in this thread | | | Date | Sat, 18 Aug 2007 20:07:32 +0530 (IST) | From | Satyam Sharma <> | Subject | Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio |
| |
On Fri, 17 Aug 2007, Geert Uytterhoeven wrote:
> On Thu, 16 Aug 2007, NeilBrown wrote: > [...] > > dev_dbg(&dev->sbd.core, > > "%s:%u: bio %u: %u segs %u sectors from %lu\n", > > - __func__, __LINE__, i, bio_segments(bio), > > - bio_sectors(bio), sector); > > - bio_for_each_segment(bvec, bio, j) { > > + __func__, __LINE__, i, bio_segments(iter.bio), > > + bio_sectors(iter.bio), > > + (unsigned long)iter.bio->bi_sector); > ^^^^^^^^^^^^^^^ > Superfluous cast: PS3 is 64-bit only, and casts are evil.
(Sorry for butting in), but I wonder if relying on that in code here (granted, a PS3-only driver, but it's in drivers/ and not arch/) would be good style. Why not just print it out as: "%llu" and use an (unsigned long long) cast, considering that's the largest type sector_t can ever have (irrespective of arch) ... I can see most of the other generic places in the kernel (such as in drivers/md/) also using the latter (%llu with unsigned long long cast) to get bi_sector printed. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |