Messages in this thread | | | Date | Thu, 16 Aug 2007 19:51:22 +0530 (IST) | From | Satyam Sharma <> | Subject | Re: [PATCH 0/6] checkpatch checks for trailing semicolons on conditionals |
| |
On Thu, 16 Aug 2007, Andy Whitcroft wrote:
> A couple of people suggested adding checks to checkpatch for trailing > semicolons on conditionals, where the conditional block may not be > actually conditional: > > if (err); > return err; > > While regression testing the changes, I ran these checks across the > whole of 2.6.23-rc3 and there appear to be 5 places where this is > occurs (above and beyond the IPv6 one which triggered this effort) > and a benign use which could be confused later which it seems safest > to fix. > > Following this email are 6 patches for these issues, relevant > maintainers cc'd. All against 2.6.23-rc3
Amazing :-) All 6 obviously correct, and one of those 5 bugs was around for more than ~2 years! But most of these made one wonder (sadly) about the (lack of) testing code got before getting merged, considering some (#2 and 6, at least) should've been obvious immediately on basic testing of the new feature, I think. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |