lkml.org 
[lkml]   [2007]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch] sched: fix broken smt/mc optimizations with CFS
    Ingo, let me know if there any side effects of this change. Thanks.
    ---

    On a four package system with HT - HT load balancing optimizations
    were broken. For example, if two tasks end up running on two logical
    threads of one of the packages, scheduler is not able to pull one of
    the tasks to a completely idle package.

    In this scenario, for nice-0 tasks, imbalance calculated by scheduler
    will be 512 and find_busiest_queue() will return 0 (as each cpu's load
    is 1024 > imbalance and has only one task running).

    Similarly MC scheduler optimizations also get fixed with this patch.

    Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
    ---

    diff --git a/kernel/sched.c b/kernel/sched.c
    index 45e17b8..c5ac710 100644
    --- a/kernel/sched.c
    +++ b/kernel/sched.c
    @@ -2494,7 +2494,7 @@ group_next:
    * a think about bumping its value to force at least one task to be
    * moved
    */
    - if (*imbalance + SCHED_LOAD_SCALE_FUZZ < busiest_load_per_task/2) {
    + if (*imbalance < busiest_load_per_task) {
    unsigned long tmp, pwr_now, pwr_move;
    unsigned int imbn;

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-08-16 03:11    [W:2.088 / U:0.952 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site