Messages in this thread Patch in this message | | | From | NeilBrown <> | Date | Thu, 16 Aug 2007 10:38:39 +1000 | Subject | [PATCH 001 of 2] md: Make sure a re-add after a restart honours bitmap when resyncing. |
| |
Commit 1757128438d41670ded8bc3bc735325cc07dc8f9 was slightly bad. If an array has a write-intent bitmap, and you remove a drive, then readd it, only the changed parts should be resynced. However after the above commit, this only works if the array has not been shut down and restarted.
This is because it sets 'fullsync' at little more often than it should. This patch is more careful.
Signed-off-by: Neil Brown <neilb@suse.de>
### Diffstat output ./drivers/md/raid1.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff .prev/drivers/md/raid1.c ./drivers/md/raid1.c --- .prev/drivers/md/raid1.c 2007-08-16 10:27:57.000000000 +1000 +++ ./drivers/md/raid1.c 2007-08-16 10:27:57.000000000 +1000 @@ -1972,7 +1972,8 @@ static int run(mddev_t *mddev) !test_bit(In_sync, &disk->rdev->flags)) { disk->head_position = 0; mddev->degraded++; - conf->fullsync = 1; + if (disk->rdev) + conf->fullsync = 1; } } if (mddev->degraded == conf->raid_disks) { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |