Messages in this thread | | | Date | Sun, 12 Aug 2007 12:50:44 -0700 (PDT) | From | Casey Schaufler <> | Subject | Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel |
| |
--- Jan Engelhardt <jengelh@computergmbh.de> wrote:
> >> >+static int smack_task_movememory(struct task_struct *p) > >> >+{ > >> >+ int rc; > >> >+ > >> >+ rc = smk_curacc(smk_of_task(p), MAY_WRITE); > >> >+ return rc; > >> >+} > >> > >> Uh... > >> > >> { > >> return smk_curacc(smk_of_task(p), MAY_WRITE); > >> } > >> > >> (also others) > > > >That was a little excessive, wasn't it? > > How do you mean? I was just suggesting to collapse the three [four] lines > into > one, getting rid of the tempotemporaries in a lot of these functions, > for example,
Sorry, I meant that my code was excessive, not your comment. Your comment was fine and most welcome. I'm sorry that I was unclear and sounded defensive.
Casey Schaufler casey@schaufler-ca.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |