Messages in this thread | | | From | (Eric W. Biederman) | Subject | Re: + sysctl-remove-binary-sysctl-support-where-it-clearly-doesnt-work.patch added to -mm tree | Date | Fri, 10 Aug 2007 03:26:52 -0600 |
| |
Alexey Dobriyan <adobriyan@sw.ru> writes:
>> @@ -1124,7 +1118,6 @@ static struct ctl_table fs_table[] = { >> .proc_handler = &proc_dointvec, >> }, >> { >> - .ctl_name = FS_NRFILE, >> .procname = "file-nr", >> .data = &files_stat, >> .maxlen = 3*sizeof(int), > > Why? It will work just fine through default sysctl(2) writeback.
Well write doesn't happen. But even more so proc_nr_files() dynamically generates files_stat.nr_files. That doesn't happen on the generic sysctl path, and thus it's broken.
Yes. I'm being picky, because at some point in the past before that was a per cpu variable the code worked, and won't look broken now unless you examine the contents of the data.
Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |