lkml.org 
[lkml]   [2007]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls
    > In that code we could just do a test on valp (i.e. data in struct
    > ctl_table).

    Or you could pass the struct pointer and subtract the array start

    > I just wanted something stupid and simple, so the -mm tree would not
    > be full of broken sysctls.

    Well I'd like you to not replace one pile of hard to clean up but easy to
    locate crap by smearing other hard to fix in one go crap over the kernel.
    >
    > At least to my eyes the code doesn't look much worse. But if you
    > want to do something better feel free.

    I'll add it to my todo list. But in the meantime I still NAK the change.
    I'll try and get a patch sorted but it'll be after the kernel summit for
    sure.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-10 19:13    [W:0.022 / U:29.340 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site