lkml.org 
[lkml]   [2007]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[RFC PATCH] type safe allocator
    From
    Date
    I wonder why we don't have type safe object allocators a-la new() in
    C++ or g_new() in glib?

    fooptr = k_new(struct foo, GFP_KERNEL);

    is nicer and more descriptive than

    fooptr = kmalloc(sizeof(*fooptr), GFP_KERNEL);

    and more safe than

    fooptr = kmalloc(sizeof(struct foo), GFP_KERNEL);

    And we have zillions of both variants.

    Note, I'm not advocating mass replacement, but using this in new code,
    and gradually converting old ones whenever they need touching anyway.

    Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
    ---

    Index: linux-2.6.22/include/linux/slab.h
    ===================================================================
    --- linux-2.6.22.orig/include/linux/slab.h 2007-07-09 01:32:17.000000000 +0200
    +++ linux-2.6.22/include/linux/slab.h 2007-08-01 10:42:45.000000000 +0200
    @@ -110,6 +110,38 @@ static inline void *kcalloc(size_t n, si
    return __kzalloc(n * size, flags);
    }

    +/**
    + * k_new - allocate given type object
    + * @type: the type of the object to allocate
    + * @flags: the type of memory to allocate.
    + */
    +#define k_new(type, flags) ((type *) kmalloc(sizeof(type), flags))
    +
    +/**
    + * k_new0 - allocate given type object, zero out allocated space
    + * @type: the type of the object to allocate
    + * @flags: the type of memory to allocate.
    + */
    +#define k_new0(type, flags) ((type *) kzalloc(sizeof(type), flags))
    +
    +/**
    + * k_new_array - allocate array of given type object
    + * @type: the type of the object to allocate
    + * @len: the length of the array
    + * @flags: the type of memory to allocate.
    + */
    +#define k_new_array(type, len, flags) \
    + ((type *) kmalloc(sizeof(type) * (len), flags))
    +
    +/**
    + * k_new0_array - allocate array of given type object, zero out allocated space
    + * @type: the type of the object to allocate
    + * @len: the length of the array
    + * @flags: the type of memory to allocate.
    + */
    +#define k_new0_array(type, len, flags) \
    + ((type *) kzalloc(sizeof(type) * (len), flags))
    +
    /*
    * Allocator specific definitions. These are mainly used to establish optimized
    * ways to convert kmalloc() calls to kmem_cache_alloc() invocations by selecting
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-08-01 11:09    [W:2.419 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site