Messages in this thread | | | Date | Thu, 2 Aug 2007 09:14:10 +0530 (IST) | From | Satyam Sharma <> | Subject | Re: [PATCH] Fix WARN_ON() on bitfield ops for all other archs |
| |
On Thu, 2 Aug 2007, Heiko Carstens wrote:
> From: Heiko Carstens <heiko.carstens@de.ibm.com> > > Fixes WARN_ON() on bitfiels ops for all architectures that have > been left out in 8d4fbcfbe0a4bfc73e7f0297c59ae514e1f1436f.
Well, considering ...
On Tue, 31 Jul 2007, Alexey Dobriyan wrote: > But I question the rationale of that commit: > [...] > I think that second case is more clear and immediately understandable.
and
On Tue, 31 Jul 2007, Linus Torvalds wrote: > For all I know, the proper solution is > to just revert the whole mess, and *not* make WARN_ON() return a value > at all, since that seems to be the fundamental mistake here.
... I think it makes sense to stop returning the value from WARN_ON() in the first place. There's only 5 places in the tree that uses its return value anyway, and one of them ( net/xfrm/xfrm_policy.c:681 ) is a good example of why it's less readable that way.
Satyam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |