Messages in this thread | | | Date | Thu, 2 Aug 2007 01:49:02 +0200 | From | Lennert Buytenhek <> | Subject | Re: [PATCH][RFC] unbreak generic futex_atomic_cmpxchg_inatomic() on UP |
| |
On Thu, Aug 02, 2007 at 01:00:21AM +0200, Mikael Pettersson wrote:
> @@ -52,7 +53,34 @@ futex_atomic_op_inuser (int encoded_op, > static inline int > futex_atomic_cmpxchg_inatomic(int __user *uaddr, int oldval, int newval) > { > +#ifdef CONFIG_SMP > return -ENOSYS; > +#else
Since the callers of futex_atomic_cmpxchg_inatomic() don't really seem prepared to deal with -ENOSYS (e.g. the handle_futex_death() infinite loop when it gets -ENOSYS), it seems better never to return -ENOSYS from this function at all.
What if you just stick an #error in here in the SMP case? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |