lkml.org 
[lkml]   [2007]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: debugfs helper for decimal challenged
    On Wed, Aug 01, 2007 at 05:52:58PM -0400, Robin Getz wrote:
    > Greg:
    >
    > For those of us who forget that when bits 21 and bit 31 in a hardware
    > register exposed with debugfs, I should see 2149580800 when I cat it (vs
    > 0x80200000), any objections to providing a hex output interface to the
    > debugfs?
    >
    > Since the input side already takes decimal & hex, I don't think this is a big
    > change:
    >
    > DEFINE_SIMPLE_ATTRIBUTE(fops_x16, debugfs_u16_get, debugfs_u16_set, "0x%04llx\n");
    >
    > struct dentry *debugfs_create_x16(const char *name, mode_t mode,
    > struct dentry *parent, u16 *value)
    > {
    > return debugfs_create_file(name, mode, parent, value, &fops_x16);
    > }
    >
    > DEFINE_SIMPLE_ATTRIBUTE(fops_x32, debugfs_u32_get, debugfs_u32_set, "0x%08llx\n");
    >
    > struct dentry *debugfs_create_x32(const char *name, mode_t mode,
    > struct dentry *parent, u32 *value)
    > {
    > return debugfs_create_file(name, mode, parent, value, &fops_x32);
    > }
    >
    > If this is OK - I will send a real patch.

    That sounds good to me, feel free to send a real patch.

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-02 00:27    [W:0.020 / U:33.212 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site