lkml.org 
[lkml]   [2007]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: 2.6.22: oops in sbp2_remove_device
    On  1 Aug, Olaf Hering wrote:
    > This happens when attaching a firewire disk (momobay) to a single cpu
    > G5. I suspect there are two bugs, one is the error handling and one is
    > the DMA mask setting.
    >
    > ieee1394: Node added: ID:BUS[0-00:1023] GUID[00010410100036e0]
    > ieee1394: Host added: ID:BUS[0-01:1023] GUID[000a95fffea65d66]
    > ReiserFS: sdb4: Using r5 hash to sort names
    > ieee1394: sbp2: failed to set 4GB DMA mask
    > Unable to handle kernel paging request for data at address 0x00000000
    > ...
    > NIP [d0000000002b48dc] .sbp2_remove_device+0x78/0x498 [sbp2]
    > LR [d0000000002b48c8] .sbp2_remove_device+0x64/0x498 [sbp2]
    > Call Trace:
    > [c00000000f1a3670] [d0000000002b48c8] .sbp2_remove_device+0x64/0x498 [sbp2] (unreliable)
    > [c00000000f1a3730] [d0000000002b5f38] .sbp2_probe+0x77c/0x7d4 [sbp2]
    > [c00000000f1a37e0] [c0000000002ca2a0] .driver_probe_device+0x13c/0x200


    I have now idea why dma_set_mask failed, nor do I see where the
    subsequent oops came from.


    From: Stefan Richter <stefanr@s5r6.in-berlin.de>
    Subject: ieee1394: revert "sbp2: enforce 32bit DMA mapping"

    Revert commit 0555659d63c285ceb7ead3115532e1b71b0f27a7 from 2.6.22-rc1.
    The dma_set_mask call somehow failed on a PowerMac G5, PPC64:
    http://lkml.org/lkml/2007/8/1/344

    Should there ever occur a DMA mapping beyond the physical DMA range, a
    proper SBP-2 firmware will report transport errors. So let's leave it
    at that.

    Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
    ---
    drivers/ieee1394/sbp2.c | 5 -----
    1 file changed, 5 deletions(-)

    Index: linux/drivers/ieee1394/sbp2.c
    ===================================================================
    --- linux.orig/drivers/ieee1394/sbp2.c
    +++ linux/drivers/ieee1394/sbp2.c
    @@ -773,11 +773,6 @@ static struct sbp2_lu *sbp2_alloc_device
    SBP2_ERR("failed to register lower 4GB address range");
    goto failed_alloc;
    }
    -#else
    - if (dma_set_mask(hi->host->device.parent, DMA_32BIT_MASK)) {
    - SBP2_ERR("failed to set 4GB DMA mask");
    - goto failed_alloc;
    - }
    #endif
    }


    --
    Stefan Richter
    -=====-=-=== =--- ----=
    http://arcgraph.de/sr/
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-01 20:33    [W:0.025 / U:88.480 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site