[lkml]   [2007]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

    Segher Boessenkool wrote:

    >>>> + ide@f0000000 {
    >>>> + compatible = "mmio-ide";
    >>>> + device_type = "ide";

    >>> Why not "ata"?

    > The hardware is called (E)IDE, the protocol is called ATA.

    Sorry for not denouncing this earlier. :-)
    ATA is the name of ANSI standard describing IDE.

    > Or that's what I was told --

    Re-check your sources. ;-)

    > I think there's some historic revisionism involved, too.

    IDE was probably an initial name of the infamous disk hardware/protocol
    later standardized as ATA, EIDE (being more of a trademark) more or less
    equals to ATA-2.

    >> Also, what mmio-ide in the compat properly means in the context of
    >> ide_platform which is able to handle both port and memory mapped IDE.
    >> I think
    >> we must get rid with this crap, and since this IDE register mapping is
    >> pretty
    >> much board specific, call it something like "mpc8349emitx-ide" instead.

    > "mmio-ide" simply is not specific enough. The device_type


    > should go, too.

    > If this IDE interface is board-specific, thee "compatible"

    It's "thy", not "thee". ;-)

    > property should include the board vendor name and board
    > name. Oh, that's what "emitx" tries to do -- it could be
    > a bit clearer perhaps ;-)

    Yeah, I forgot about the vondor's "fsl," prefix.

    > Segher

    MBR, Sergei
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-08-01 15:13    [W:0.028 / U:3.332 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site