lkml.org 
[lkml]   [2007]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Two trivial whitespace fixes in lockdep/spinlock code
From
Date
On Tue, 2007-07-03 at 17:16 -0700, Andrew Morton wrote:
> On Wed, 4 Jul 2007 02:14:42 +0200 (CEST) Jiri Kosina <jkosina@suse.cz> wrote:
>
> > From: Jiri Kosina <jkosina@suse.cz>
> >
> > Two trivial whitespace fixes in lockdep/spinlock code
> >
> > Cc: Ingo Molnar <mingo@elte.hu>
> > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> >
> > diff --git a/kernel/lockdep.c b/kernel/lockdep.c
> > index 1a5ff22..12ca5fd 100644
> > --- a/kernel/lockdep.c
> > +++ b/kernel/lockdep.c
> > @@ -1222,7 +1222,7 @@ register_lock_class(struct lockdep_map *lock, unsigned int subclass, int force)
> >
> > /*
> > * Debug-check: all keys must be persistent!
> > - */
> > + */
> > if (!static_obj(lock->key)) {
> > debug_locks_off();
> > printk("INFO: trying to register non-static key.\n");
> > diff --git a/kernel/spinlock.c b/kernel/spinlock.c
> > index 2c6c2bf..5386d7e 100644
> > --- a/kernel/spinlock.c
> > +++ b/kernel/spinlock.c
> > @@ -28,7 +28,7 @@ int __lockfunc _spin_trylock(spinlock_t *lock)
> > spin_acquire(&lock->dep_map, 0, 1, _RET_IP_);
> > return 1;
> > }
> > -
> > +
> > preempt_enable();
> > return 0;
> > }
>
> Too trivial, sorry: we could generate 8 million patches like this.

Would you rather have one big patch that fixes a lot of this type of
stuff, or not have these types of patches at all ?

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-09 19:57    [W:0.076 / U:6.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site