lkml.org 
[lkml]   [2007]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 19/20] KVM: Tune hotplug/suspend IPIs
    Date
    The hotplug IPIs can be called from the cpu on which we are currently
    running on, so use on_cpu(). Similarly, drop on_each_cpu() for the
    suspend/resume callbacks, as we're in atomic context here and only one
    cpu is up anyway.

    Signed-off-by: Avi Kivity <avi@qumranet.com>
    ---
    drivers/kvm/kvm_main.c | 8 ++++----
    1 files changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c
    index 3226ad4..54cad51 100644
    --- a/drivers/kvm/kvm_main.c
    +++ b/drivers/kvm/kvm_main.c
    @@ -3010,13 +3010,13 @@ static int kvm_cpu_hotplug(struct notifier_block *notifier, unsigned long val,
    case CPU_UP_CANCELED_FROZEN:
    printk(KERN_INFO "kvm: disabling virtualization on CPU%d\n",
    cpu);
    - smp_call_function_single(cpu, hardware_disable, NULL, 0, 1);
    + on_cpu(cpu, hardware_disable, NULL, 0, 1);
    break;
    case CPU_ONLINE:
    case CPU_ONLINE_FROZEN:
    printk(KERN_INFO "kvm: enabling virtualization on CPU%d\n",
    cpu);
    - smp_call_function_single(cpu, hardware_enable, NULL, 0, 1);
    + on_cpu(cpu, hardware_enable, NULL, 0, 1);
    break;
    }
    return NOTIFY_OK;
    @@ -3110,13 +3110,13 @@ static void kvm_exit_debug(void)

    static int kvm_suspend(struct sys_device *dev, pm_message_t state)
    {
    - on_each_cpu(hardware_disable, NULL, 0, 0);
    + hardware_disable(NULL);
    return 0;
    }

    static int kvm_resume(struct sys_device *dev)
    {
    - on_each_cpu(hardware_disable, NULL, 0, 0);
    + hardware_enable(NULL);
    return 0;
    }

    --
    1.5.2.2
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-08 14:03    [W:0.019 / U:58.876 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site