Messages in this thread | | | Date | Mon, 9 Jul 2007 01:17:26 +0200 | From | Adrian Bunk <> | Subject | Re: Please revert 21564fd2a3deb48200b595332f9ed4c9f311f2a7 |
| |
On Mon, Jul 09, 2007 at 01:02:21AM +0200, Andi Kleen wrote: > On Monday 09 July 2007 00:44:44 Adrian Bunk wrote: > > On Sun, Jun 17, 2007 at 09:43:51PM -0700, Jeremy Fitzhardinge wrote: > > > Adrian Bunk wrote: > > >... > > > > Andi forwarded it although the following people had already NAK'ed it: > > > > - Christoph Hellwig [1] > > > > - Peter Zijlstra [2] > > > > - Alan Cox [3] > > > > > > > > Considering that Andi forwarded it 2 days after he himself said a > > > > different solution was pending [4] I assume he mistakenly sent it for > > > > inclusion in your tree. > > > > > > > > > > We played with some ideas, but they all turned out way too ugly to live. > > > > Andi got some NAK's, said himself it will be solved differently, and > > two days later he submits the NAK'ed patch into Linus' tree. > > It will be solved differently longer term, but short term the fix > was still needed. There are limits on what can be done late > in the release cycle so simple patches win.
Your patch got into Linus' tree in the middle of the merge window...
> Besides none of the "NAK"s were particularly inspired in my opinion; > there were no clear technical objections brought forward.
Why didn't you say this?
Your answer in [1] didn't sound as if you would submit this patch, and even less that you would submit it just two days later.
> -Andi
cu Adrian
[1] http://lkml.org/lkml/2007/4/30/335
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |