lkml.org 
[lkml]   [2007]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -mm 7/9] netconsole: Support multiple logging targets
    Hi Satyam,

    The following comments aren't essential.

    > if (!(event == NETDEV_UP || event == NETDEV_DOWN ||
    > event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
    > - goto done;
    > + goto done;

    The above diff lines are extra.

    > + spin_lock_irqsave(&target_list_lock, flags);
    > + list_for_each_entry(nt, &target_list, list) {
    > + if (nt->np.dev == dev) {
    > + switch (event) {
    > + case NETDEV_UP:
    > + case NETDEV_DOWN:
    > + nt->dev_status = net_dev_is_up(nt->np.dev);
    > + break;
    > +
    > + case NETDEV_CHANGEADDR:
    > + memcpy(nt->np.local_mac, dev->dev_addr, ETH_ALEN);

    The above line is over 80 characters.

    Thanks,
    --
    Keiichi KII
    NEC Corporation OSS Platform Development Division
    E-mail: k-keiichi@bx.jp.nec.com



    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-07 20:39    [W:0.021 / U:60.604 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site