lkml.org 
[lkml]   [2007]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] some kmalloc/memset ->kzalloc (tree wide)
On Fri, 6 Jul 2007 18:07:20 -0400 (EDT)
James Morris <jmorris@namei.org> wrote:

> On Fri, 6 Jul 2007, Heikki Orsila wrote:
>
> > > Transform some calls to kmalloc/memset to a single kzalloc (or
> > > kcalloc).
> >
> > I looked all the files through. They looked good to me, except
> > one case:
>
> I checked the drivers/net and net/ changes and they looked ok (aside from
> the above).
>
>

OK, thanks for checking it, guys.

Yoann, the "tree wide" thing really is a problem. Your patch here is
touching ten or more maintainers' code and it really does want to be split
into ten separate patches and fed into the tree via the appropriate routes.

I can take care of that routing if I have the ten patches, but this time I
really can't be bothered splitting the patch up (it's rather boring, and
gets error-prone).

For this patch, I tossed out the ten or so hunks which conflicted with
other pending patches in the various trees and I shall just grit the teeth
and maintain and merge it as a single whopping patch. (At least this way
I'll actually get some scsi stuff merged). Anything which conflicts with
anyone's outstanding work will be dropped.

For any future patches, _please_ split them up along some sane lines.
Generally you'll find that one patch per second-level directory works
pretty well: drivers/net, drivers/scsi, drivers/usb, fs/ext2, drivers/char,
etc.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-07 01:19    [W:0.050 / U:0.732 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site