lkml.org 
[lkml]   [2007]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] I386: Deactivate the test for the dead CONFIG_BALANCED_IRQ_DEBUG variable.
Robert P. J. Day wrote:
> --- a/arch/i386/kernel/io_apic.c
> +++ b/arch/i386/kernel/io_apic.c
> @@ -353,7 +353,7 @@ static void set_ioapic_affinity_irq(unsigned int irq, cpumask_t cpumask)
> # include <linux/slab.h> /* kmalloc() */
> # include <linux/timer.h> /* time_after() */
>
> -#ifdef CONFIG_BALANCED_IRQ_DEBUG
> +#if 0 /* debug IRQ balancing */
> # define TDprintk(x...) do { printk("<%ld:%s:%d>: ", jiffies, __FILE__, __LINE__); printk(x); } while (0)
> # define Dprintk(x...) do { TDprintk(x); } while (0)
> # else

Regarding the Subject: Perhaps it's not of type "dead (K)config
variable"in the strict sense but rather of the type "local macro whose
name was unbefittingly taken from CONFIG_ namespace".

BTW, when I suggested the "#if 0" to you, I forgot that some developers
might be interested in compiling their kernel with
-DCONFIG_BALANCED_IRQ_DEBUG injected via the commandline. But we'll hear
from them if that's the case.

On the other hand, these debug macros seem to be very old. I'll have a
closer look with qgit/git-blame later today. Maybe it's time to remove
them now.
--
Stefan Richter
-=====-=-=== -=== --==-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-06 15:59    [W:0.064 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site