Messages in this thread | | | Subject | Re: [PATCH] debug work struct cancel deadlocks with lockdep | From | Johannes Berg <> | Date | Thu, 05 Jul 2007 11:19:46 +0200 |
| |
On Thu, 2007-07-05 at 11:10 +0200, Peter Zijlstra wrote:
> > +/* both _name and _key must not be NULL */
Heh actually I got confused. The requirement that _key is not NULL comes from the fact that I need to copy it for the workqueue stuff, not from lockdep. Hence, only _name must be non-NULL, I'll change the comment to reflect that.
> > +#define STATIC_LOCKDEP_MAP_INIT(_name, _key) \ > > + { .name = (_name), .key = (_key), } > > looks sane enough :-)
:)
I'll repost with these minor changes directly to akpm tomorrow then; no lockdep support on my powerbook that I'm using right now so I can't even compile-test.
johannes [unhandled content-type:application/pgp-signature] | |