lkml.org 
[lkml]   [2007]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] debug work struct cancel deadlocks with lockdep
From
Date
On Thu, 2007-07-05 at 10:45 +0200, Ingo Molnar wrote:

> > +#ifdef CONFIG_LOCKDEP
> > + /*
> > + * It is permissible to free the struct work_struct
> > + * from inside the function that is called from it,
> > + * this we need to take into account for lockdep too.
> > + * To avoid bogus "held lock freed" warnings as well
> > + * as problems when looking into work->lockdep_map,
> > + * make a copy and use that here.
> > + */
> > + struct lockdep_map lockdep_map = work->lockdep_map;
> > +#endif
>
> > + lock_acquire(&lockdep_map, 0, 0, 0, 2, _THIS_IP_);
> > f(work);
> > + lock_release(&lockdep_map, 1, _THIS_IP_);
>
> neat trick :)

Not like I had a choice ;) But since I assign .key it still works :)

Btw, do you have a tree you'll submit this through, or Oleg, or should I
send it to akpm after we sort out any further issues?

johannes
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2007-07-05 10:53    [W:0.057 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site