lkml.org 
[lkml]   [2007]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] dio: remove bogus refcounting BUG_ON
From
Date
On Thu, 2007-07-05 at 10:11 -0700, Zach Brown wrote:
> > the BUG_ON(). But unfortunately, our perf. team is able reproduce the
> > problem.
>
> What are they doing to reproduce it? How much setup does it take?

Huge OLTP run :(

>
> > Debug indicated that, the ret2 == 1 :(
>
> That could be consistent with the theory that we're racing with the
> dio struct being freed and reused before it's tested in the BUG_ON()
> condition. Suparna's suggestion to sample dio->is_async before
> releasing the refcount and using that in the BUG_ON condition is a
> good one.

I will ask them to try that.

Thanks,
Badari

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-05 19:19    [W:0.033 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site