Messages in this thread | | | Date | Wed, 4 Jul 2007 11:27:32 +0100 (BST) | From | Mark Fortescue <> | Subject | Re: [PATCH] Re: Sparc32: random invalid instruction occourances on sparc32 (sun4c) |
| |
Hi David,
Another related point that may also need to be considered is that I think I am correct in saying that on ARM and on the 64bit platforms, sizeof (unsigned long long) is 16 (128bits).
Should the RedZone words be specified as __u64 not the unsigned long long used or does the alignment need to be that of unsigned long long ?
Regards Mark Fortescue.
On Tue, 3 Jul 2007, David Woodhouse wrote:
> On Wed, 2007-07-04 at 04:27 +0100, Mark Fortescue wrote: >> I tried the previous patch and it looks like it fixes the issue however >> one of the test builds I did caused depmod to use up all available memory >> (40M - kernel memory) before taking out the kernel with the oom killer. >> At present, I do not know if it is a depmod issue or a kernel issue. >> I will have to do some more tests later on to day. > > That's almost certain to be an unrelated issue. > >> I have looked at the latest patch below and am I am still not sure about >> two areas. Please take a look at my offering based on your latest >> patch (included here to it will probably get mangled). >> >> Note the change to lines 2178 to 2185. I have also changed/moved the >> alignment of size (see lines 2197 to 2206) based on your changes. > > The first looks correct; well spotted. The second is just cosmetic but > also seems correct. I might be inclined to make the #define > 'RED_ZONE_ALIGN' and use it in the other places too. > > -- > dwmw2 > > - > To unsubscribe from this list: send the line "unsubscribe sparclinux" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |