lkml.org 
[lkml]   [2007]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Optional Beeping During Resume From Suspend To Ram.
Date
Hi.

On Thursday 05 July 2007 07:29:07 Pavel Machek wrote:
> Here's the version that uses just one variable, relative to Nigel's
> patch. Hmm, and it also closes nasty trap for the user in
> acpi_sleep_setup; order of parameters actually mattered there,
> acpi_sleep=s3_bios,s3_mode doing something different from
> acpi_sleep=s3_mode,s3_bios . It actually works here.

Good catch.

> Will you fold it into patch28, or should I create a changelog?
> Testing welcome :-).

I really dislike the overloading of acpi video flags in this way. You yourself
have said in the past that new functionality should use /sys instead
of /proc, and here you are overloading an existing variable for the sake of
expediency. Please, stick with a new /sys/power entry.

Documentation is also an issue. Your patch should update the kernel_parameters
file so users can know how to get the beeping to happen. It would be nice if
it mentioned the proc entry too.

[...]

> @@ -80,9 +82,11 @@ static int __init acpi_sleep_setup(char
>
> __setup("acpi_sleep=", acpi_sleep_setup);
>
> +/* Ouch, we want to delete this. We already have better version in
userspace, in
> + s2ram from suspend.sf.net project */

Do we? This version has advantages in not requiring any userspace app and in
being able to work even if you can't yet get as far as having userspace
working. [Reads more] Oh, do you mean a better way of setting this parameter
(ie requiring the userspace app and then having it echo $VALUE
> /proc/sys/kernel/acpi_video_flags? Considering we're not going to suspend
to ram during init scripts, we have a way of setting/resetting it post-boot
with or without s2m and the flag doesn't therefore need to be command line
option, I can go with that. Does it need a patch to mark it as deprecated?

[...]

> @@ -124,7 +124,7 @@ real_save_cr3: .long 0
> real_save_cr4: .long 0
> real_magic: .long 0
> video_mode: .long 0
> -video_flags: .long 0
> +realmode_flags: .long 0
> beep_flags: .long 0
> real_efer_save_restore: .long 0
> real_save_efer_edx: .long 0

Beep_flags should be removed too if you're sticking with /proc.

Regards,

Nigel
--
See http://www.tuxonice.net for Howtos, FAQs, mailing
lists, wiki and bugzilla info.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2007-07-05 00:37    [W:0.080 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site