lkml.org 
[lkml]   [2007]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -mm 5/9] netconsole: Introduce dev_status member
    On Wed, 4 Jul 2007, Matt Mackall wrote:
    > On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote:
    > > [...]
    > > +/*
    > > + * Why no net_dev_is_up() in netdevice.h? The kernel could lose a lot of
    > > + * weight if only netdevice.h had the good sense to export such a function.
    > > + * Oh well ...
    > > + */
    > > +static inline int net_dev_is_up(struct net_device *net_dev)
    > > +{
    > > + return ((net_dev->flags & IFF_UP) == IFF_UP);
    > > +}
    >
    > Why editorialize? Why not just add this to netdevice.h?

    Hmm, I wanted to keep all changes local to netconsole, but ...
    ok, will do that.

    > > + if (nt->dev_status) {
    >
    > Why not simply call net_dev_is_up?

    Yes, I did consider just calling the function here instead of
    introducing another member ... again, ok will do that ...

    > > We then join this up with the just-introduced net_device notifier, and
    > > introduce NETDEV_UP and NETDEV_DOWN notifications. By disabling the target
    > > when the corresponding local interface is down, we save the overhead of
    > > unnecessarily disabling interrupts and calling into the netpoll stack in
    > > console->write().
    >
    > Yuck.

    ... so all this will go too.

    Satyam
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-04 18:15    [W:0.021 / U:89.836 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site