Messages in this thread | | | Date | Tue, 31 Jul 2007 10:38:48 +0200 | From | Zoltan Menyhart <> | Subject | Re: [PATCH] flush icache before set_pte take6. [4/4] optimization for cpus other than montecito |
| |
David Mosberger-Tang wrote: > This seems crazy to me. Flushing should occur according to the > *architecture*, not model-by-model. Even if we happen to get "lucky" > on pre-Montecito CPUs, that doesn't justify such ugly hacks. Or you > really want to debug this *again* come next CPU? > > --david
O.K. let's say we flush by default: the global flag is set.
We can have a (short) list of the CPU models which do not require this flush.
If all of the CPUs are on the list then clear the global flag. And:
static inline void sync_icache_dcache(pte_t pte) { if (pte_exec(pte) && global_flag) __sync_icache_dcache(pte); }
Thanks,
Zoltan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |