lkml.org 
[lkml]   [2007]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fs/partitions/check.c: add_partition() warning fixes
Hi Cornelia,

Cornelia Huck wrote:
> On Sun, 29 Jul 2007 10:53:39 +0800,
> Eugene Teo <eugeneteo@kernel.sg> wrote:
[...]
>> + return;
>> +
>> +err_out_del_link:
>> + sysfs_remove_link(&p->kobj, "subsystem");
>
> You need a remove uevent if you did an add uevent above.
>
>> +err_out_del_kobj:
>> + kobject_del(&p->kobj);
>> +err_out:
>> + kfree(p);
>
> Please use kobject_put() instead.

Thanks for your feedback.

Eugene
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-30 11:47    [W:0.076 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site