Messages in this thread | | | Date | Mon, 30 Jul 2007 14:24:30 +0530 (IST) | From | Satyam Sharma <> | Subject | Re: [linux-usb-devel] [PATCH] USB Pegasus driver - avoid a potential NULL pointer dereference. |
| |
On Mon, 30 Jul 2007, Petko Manolov wrote:
> On Sun, 29 Jul 2007, Oliver Neukum wrote: > > > [...] > > pegasus == NULL there would be a kernel bug. Silently ignoring > > it, like the code now wants to do is bad. As the oops has never been > > reported, I figure turning it into an explicit debugging test is overkill, > > so removal seems to be the best option. > > In the past urb->context was not guaranteed to be non-null for any > asynchronous calls. If this is not the case anymore then it should be removed > from at least two more locations in the driver. > > Attached you'll find the resulting patch.
Given Oliver's earlier comment, it looks okay to me. Thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |