lkml.org 
[lkml]   [2007]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] add check do_direct_IO() return val
    From
    Date
    On Mon, 2007-07-30 at 13:53 -0700, Andrew Morton wrote:
    > On Sat, 28 Jul 2007 11:47:19 +0800
    > Joe Jin <joe.jin@oracle.com> wrote:
    >
    > > > I tested Andrew's patch and panic was gone but got few ENOTBLK.
    > > > So I tried with Joe's patch , both panic and ENOTBLK are gone now.
    > > > But in Joe's patch if (ret == -ENOTBLK && (rw & WRITE)), dio_cleanup(dio)
    > > > was not getting called because of break. So I moved dio_cleanup just
    > > > after if (ret).
    > >
    > > Guru, actually, break from the loop with ENOTBLK will call dio_cleanup
    > > at leater, if call it too early, that means will put_page(), maybe cause
    > > other panic.
    > >
    >
    > fyi, I dropped the earlier patch and now we have nothing. Please let's get all
    > this sorted out in time for 2.6.23. Which is still many weeks away so there is
    > plenty of time to prepare something which was carefully reviewed and well-tested,
    > thanks.

    I am also taking a look at it right now. Unfortunately, I don't think
    fix is that simple - since we need to return success, in case of a
    partial write.

    Thanks,
    Badari

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-30 23:25    [W:0.020 / U:31.624 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site