lkml.org 
[lkml]   [2007]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.23-rc1-mm1
    On Mon, Jul 30, 2007 at 11:27:20AM -0700, Andrew Morton wrote:
    > ho hum, crap. Yes, ioctl_by_bdev() doesn't have a file* and so it makes
    > unlocked_ioctl() rather tricky. We could cook up a `struct file' on the
    > stack (we do that in various places), but that sucks.
    >
    > Christoph, have you any clever suggestions?

    There's two ways to deal with it, one ugly and quick and one to do it
    right.

    The quick hack is to fake up a file struct similar to blkdev_get().

    The proper solutions is to get rid of the file (and inode) in the
    blockdev ->ioctl prototype. Only thing keeping is from that is
    floppy.c (and some cut & paste variants for m68k) due to their awkard
    permission checking hacks.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-30 20:45    [W:4.960 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site