Messages in this thread | | | Subject | Re: [PATCH] Re: Sparc32: random invalid instruction occourances on sparc32 (sun4c) | From | David Woodhouse <> | Date | Tue, 03 Jul 2007 23:33:25 -0400 |
| |
On Wed, 2007-07-04 at 04:27 +0100, Mark Fortescue wrote: > I tried the previous patch and it looks like it fixes the issue however > one of the test builds I did caused depmod to use up all available memory > (40M - kernel memory) before taking out the kernel with the oom killer. > At present, I do not know if it is a depmod issue or a kernel issue. > I will have to do some more tests later on to day.
That's almost certain to be an unrelated issue.
> I have looked at the latest patch below and am I am still not sure about > two areas. Please take a look at my offering based on your latest > patch (included here to it will probably get mangled). > > Note the change to lines 2178 to 2185. I have also changed/moved the > alignment of size (see lines 2197 to 2206) based on your changes.
The first looks correct; well spotted. The second is just cosmetic but also seems correct. I might be inclined to make the #define 'RED_ZONE_ALIGN' and use it in the other places too.
-- dwmw2
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |