Messages in this thread | | | Date | Tue, 03 Jul 2007 23:33:38 +0200 | From | Morten Helgesen <> | Subject | Re: [PATCH] genericserial: Remove bogus optimisation check and dead code paths |
| |
Alan Cox wrote: > On Tue, 03 Jul 2007 16:39:05 +0200 > Morten Helgesen <morten@sourcepoet.org> wrote: > > >> Alan Cox wrote: >> >> [...snip...] >> >>> @@ -75,11 +64,11 @@ >>> if (! (port->flags & ASYNC_INITIALIZED)) return; >>> >>> /* Take a lock on the serial tranmit buffer! */ >>> - LOCKIT; >>> + mutex_lock(& port->port_write_mutex); >>> >>> >> ^ Contains additional whitespace. >> > > > Its an old driver, it doesn't follow the coding style too well at all - > viz stuff like if (! ( the line above. Given its age and limited userbase > I don't plan to go and make it conform either, but I will take patches > for the formatting (and the spelling errors it is full of) from someone > who wants to do the work. > > Alan Ok, so how is this for a start?
- Proper indenting. - Fixes for the most obvious typos and spelling errors.
Signed-off-by: Morten Helgesen <morten@sourcepoet.org>
== Morten - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |